Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Clean CUDA Shutdown #510

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 28, 2024

Avoid double finalize and segfaults in CUDA debug runs.

Related to #348 (comment)

@ax3l ax3l added bug Something isn't working backend: cuda Specific to CUDA execution (GPUs) bug: affects latest release Bug also exists in latest release version component: python Python bindings labels Jan 28, 2024
@ax3l ax3l requested a review from atmyers January 28, 2024 21:47
@ax3l ax3l force-pushed the fix-cuda-debug-shutdown branch 4 times, most recently from bf762f0 to 858eab6 Compare January 28, 2024 22:55
Avoid double finalize and segfaults in CUDA debug runs.
Comment on lines +19 to +23
# def test_impactx_module():
# """
# Tests the basic modules we provide.
# """
# print(f"version={impactx.__version__}")

Check notice

Code scanning / CodeQL

Commented-out code Note test

This comment appears to contain commented-out code.
- tolerances as in FODO test
- device2host copy simplify for lifetime
@ax3l ax3l merged commit 63d96ae into ECP-WarpX:development Jan 29, 2024
13 of 14 checks passed
@ax3l ax3l deleted the fix-cuda-debug-shutdown branch January 29, 2024 18:40
@ax3l ax3l mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: cuda Specific to CUDA execution (GPUs) bug: affects latest release Bug also exists in latest release version bug Something isn't working component: python Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant