Disable AMReX_LINEAR_SOLVER_INCFLO by default #5364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested with the latest CUDA, HIP and SYCL compilers. The compilers seem to have improved a lot. It used to be quite slow to compile the EB tensor and nodal projection solvers. But now I only saw a few percent difference when those solvers were not included. |
ax3l
added
install
component: third party
We do not need to compile these linear solvers that are intended for incompressible flow solvers. This should speed up the build process a little bit.
ax3l
reviewed
Oct 9, 2024
ax3l
reviewed
Oct 9, 2024
ax3l
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need to compile these linear solvers that are intended for incompressible flow solvers. This should speed up the build process a little bit.
Depends on AMReX-Codes/amrex#4181