-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] openPMD: variableBased IterationEncoding #1909
Conversation
temporarily update to dev branch
Source/Diagnostics/WarpXOpenPMD.cpp
Outdated
@@ -316,6 +320,13 @@ WarpXOpenPMDPlot::Init (openPMD::Access access, bool isBTD) | |||
m_MPIRank = 1; | |||
} | |||
|
|||
if ( m_OpenPMDFileType.compare("bp") == 0 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make this a user input option.
We can default to variableBased
, fallback default: groupBased
, but the user might want to pick fileBased
for various reasons
Note that the openPMD::Series
file name should not include the _%T
placeholder for all but fileBased
iteration encoding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, so in addition to parameter "openpmd_backend", I will introduce another one called "openpmd_iteration". It is default to variableBased if available, otherwise, group based.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I will rename openpmd_tspf to openpmd_iteration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could encode it with an enum struct so that the user can pick between all three encodings :)
… for variable based, group based or file based encoding
We saw in #1842 (comment) that some of the changes to the streaming API functions, i.e. We need to double-check here again that this stays working. |
opened #1979 and closing this one. |
Implement
variableBased
openPMD iteration encoding: