Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for sr3 configuration and callback #356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RousseauLambertLP
Copy link
Contributor

update for sr3 configuration and callback

  • replaced message.py and file_.py by event_plugin.py for the callback functions. Both cases are handled in a single file.
  • event_plugin.py updated for callback instead of the previous plugin
  • added exchange xpublic to all configuration
  • updated the env var to point to the class in the callback (sr3) instead of the event file (sr2)
  • reordered amqps configuration file for consistency

msc_pygeoapi/event/event_plugin.py Outdated Show resolved Hide resolved
msc_pygeoapi/event/event_plugin.py Outdated Show resolved Hide resolved
rmv "lp-" from loader for testing

test updated main.yml

minor code updates
@Dukestep
Copy link
Contributor

We've run into an issue where the approach of having the after_work and after_accept methods in a single Event class will not work. There is no way to specify which method to call via the sr3 subscriber which triggers the callback.

Reid at SSC suggests we split them back out into individual files.

Peter also suggested adding our own option and using if statements to control which methods get run: https://metpx.github.io/sarracenia/api-documentation.html#config:~:text=with%20queue%20bindings.-,add_option(,-option%2C%20kind.

The following example is handy to: https://github.com/MetPX/sarracenia/blob/development/sarracenia/flowcb/send/email.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants