Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CanDCSU6 in GeoMet-OGC-API #302

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

RousseauLambertLP
Copy link
Contributor

Add support for CanDCSU6 in GeoMet-OGC-API

  • added collection in the conf file
  • added the provider in the code base
    This provider is based on teh climate xarray provider

Copy link
Member

@tomkralidis tomkralidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @RousseauLambertLP! See minor change requests. Note #303 which now implements f-strings.

msc_pygeoapi/provider/candcsu6_xarray.py Outdated Show resolved Hide resolved
msc_pygeoapi/provider/candcsu6_xarray.py Outdated Show resolved Hide resolved
msc_pygeoapi/provider/candcsu6_xarray.py Outdated Show resolved Hide resolved
msc_pygeoapi/provider/candcsu6_xarray.py Outdated Show resolved Hide resolved
msc_pygeoapi/provider/candcsu6_xarray.py Outdated Show resolved Hide resolved
msc_pygeoapi/provider/candcsu6_xarray.py Outdated Show resolved Hide resolved
msc_pygeoapi/provider/candcsu6_xarray.py Outdated Show resolved Hide resolved
msc_pygeoapi/provider/candcsu6_xarray.py Outdated Show resolved Hide resolved
msc_pygeoapi/provider/candcsu6_xarray.py Outdated Show resolved Hide resolved
msc_pygeoapi/provider/candcsu6_xarray.py Outdated Show resolved Hide resolved
@RousseauLambertLP RousseauLambertLP force-pushed the issue-576 branch 3 times, most recently from 595805a to 0b1179c Compare September 5, 2023 13:07
metadata works for candcsu6

update for the candcsu6 provider

added the candcsu6 collections

flake8 fixes

updated to f string

other minor changes

removed ()
@tomkralidis tomkralidis merged commit 40438b1 into ECCC-MSC:master Sep 5, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants