-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make eva-pipeline use classes of variation-commons #148
base: master
Are you sure you want to change the base?
Conversation
…asses from variation-commons-core
conf/storage-mongodb.properties
Outdated
@@ -5,24 +5,24 @@ | |||
#Variant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not include IP address or any other credentials/sensitive information in properties files.
examples/application.properties
Outdated
@@ -1,13 +1,13 @@ | |||
# EXECUTION PROFILE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've removed them
This is trying to fix issue#147
Erase all classes in commons/models, mappings are in map.txt
Add dependency on classes from commons-variations
Remove dependency on org.opencb.biodata.formats.variant.vcf4.io.VariantVcfReader and rebuild VcfHeaderReader
Build passed
Could run job load-genotyped-vcf to load variations and build homo_sapiens_variants collection successfully, however the files collection failed. run-log.txt
Correct a couple of tests. As of now test run failed with 58 errors, I am trying to fix them