Skip to content

Commit

Permalink
review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
nitin-ebi committed Feb 14, 2024
1 parent 655ba76 commit 3d37afa
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ void testGetChromosomesByMD5Checksum() {
List<ChromosomeEntity> chromosomeList = chrPage.getContent();

assertEquals(1, chromosomeList.size());
assertChromosomeIdenticalToEntity(chromosomeWithMD5, chromosomeList.get(0));
assertChromosomesIdentical(chromosomeWithMD5, chromosomeList.get(0));
assertEquals(testMD5Checksum, chromosomeList.get(0).getMd5checksum());
assertEquals(assemblyEntity.getInsdcAccession(), chromosomeList.get(0).getAssembly().getInsdcAccession());
}
Expand Down Expand Up @@ -161,11 +161,11 @@ void testGetMultipleChromosomesByMD5ChecksumInDifferentAssemblies() {
assertEquals(2, chromosomeList.size());

assertEquals(testMD5Checksum, chromosomeList.get(0).getMd5checksum());
assertChromosomeIdenticalToEntity(chromosomeWithMD51, chromosomeList.get(0));
assertChromosomesIdentical(chromosomeWithMD51, chromosomeList.get(0));
assertEquals("assembly1", chromosomeList.get(0).getAssembly().getInsdcAccession());

assertEquals(testMD5Checksum, chromosomeList.get(1).getMd5checksum());
assertChromosomeIdenticalToEntity(chromosomeWithMD52, chromosomeList.get(1));
assertChromosomesIdentical(chromosomeWithMD52, chromosomeList.get(1));
assertEquals("assembly2", chromosomeList.get(1).getAssembly().getInsdcAccession());
}

Expand All @@ -183,7 +183,7 @@ void assertChromosomeIdenticalToEntity(ChromosomeEntity chromosomeEntity) {
assertEquals(entity.getEnaSequenceName(), chromosomeEntity.getEnaSequenceName());
}

void assertChromosomeIdenticalToEntity(ChromosomeEntity chromosomeEntity1, ChromosomeEntity chromosomeEntity2) {
void assertChromosomesIdentical(ChromosomeEntity chromosomeEntity1, ChromosomeEntity chromosomeEntity2) {
assertEquals(chromosomeEntity1.getGenbankSequenceName(), chromosomeEntity2.getGenbankSequenceName());
assertEquals(chromosomeEntity1.getInsdcAccession(), chromosomeEntity2.getInsdcAccession());
assertEquals(chromosomeEntity1.getRefseq(), chromosomeEntity2.getRefseq());
Expand Down

0 comments on commit 3d37afa

Please sign in to comment.