Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVA-3570 Added recovery agent for running recovery of blocks #88

Merged
merged 2 commits into from
May 14, 2024

Conversation

nitin-ebi
Copy link
Contributor

No description provided.

@nitin-ebi nitin-ebi self-assigned this May 8, 2024
@nitin-ebi nitin-ebi requested review from tcezard and apriltuesday May 8, 2024 14:16
Copy link
Member

@tcezard tcezard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left a single optional comment.

this.monotonicDatabaseService = monotonicDatabaseService;
}

public void runRecovery(String categoryId, String applicationInstanceId, LocalDateTime lastUpdatedTime) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should add logging statement or have a way to report how many blocks were processed and how many blocks were recovered in each category.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added logger statements

@nitin-ebi nitin-ebi merged commit e5d5346 into EBIvariation:master May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants