review comments

EBIvariation · Apr 26, 2024 · 0749b6c · 0749b6c
1 parent 2a07f2c
commit 0749b6c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/...mmons-core/src/main/java/uk/ac/ebi/ampt2d/commons/accession/core/AccessioningService.java b/...mmons-core/src/main/java/uk/ac/ebi/ampt2d/commons/accession/core/AccessioningService.java
@@ -43,6 +43,8 @@ public interface AccessioningService<MODEL, HASH, ACCESSION> {
      * stored in the repository.
      *
      * @param messages List of objects to be accessioned or already accessioned
+     * @param applicationInstanceId The id of the application(instance) that is trying to generate the accessions.
+     *        This id will be used by the underlying Accession generator when reserving blocks for generating accessions.
      * @return List of wrapper objects containing the accessioned objects and their associated accessions and hashes
      * @throws AccessionCouldNotBeGeneratedException when accession could not be generated
      */

diff --git a/.../uk/ac/ebi/ampt2d/commons/accession/generators/monotonic/MonotonicAccessionGenerator.java b/.../uk/ac/ebi/ampt2d/commons/accession/generators/monotonic/MonotonicAccessionGenerator.java
@@ -123,6 +123,7 @@ public synchronized long[] generateAccessions(int numAccessionsToGenerate, Strin
      * Ensures that the available ranges queue hold @param totalAccessionsToGenerate or more elements
      *
      * @param totalAccessionsToGenerate
+     * @param applicationInstanceId - The id of the application(instance) that is trying to reserve the block
      */
     private synchronized void reserveNewBlocksUntilSizeIs(int totalAccessionsToGenerate, String applicationInstanceId) {
         while (!blockManager.hasAvailableAccessions(totalAccessionsToGenerate)) {