Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update input_output.py #73

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Update input_output.py #73

merged 1 commit into from
Sep 6, 2024

Conversation

SeaCelo
Copy link
Collaborator

@SeaCelo SeaCelo commented Aug 29, 2024

Added a backup source for the SAM in a GH repository

This adds a fallback source for the SAM if the WIDER site is down. Solves #72

cc: @GuBenda

Added a backup source for the SAM in a GH repository
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.43%. Comparing base (6e576ae) to head (0a58d9e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
ogzaf/input_output.py 60.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   56.40%   56.43%   +0.02%     
==========================================
  Files          12       12              
  Lines         367      381      +14     
==========================================
+ Hits          207      215       +8     
- Misses        160      166       +6     
Flag Coverage Δ
unittests 56.43% <60.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SeaCelo SeaCelo requested a review from jdebacker September 3, 2024 18:26
@jdebacker
Copy link
Collaborator

Thanks for this update! I also like the new repo to cache the SAM files in.

@jdebacker jdebacker merged commit f003a14 into EAPD-DRB:main Sep 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants