-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up for example scripts and macro_params.py
, pass macro data date ranges,
#71
Conversation
macro_params.py
, pass macro data date ranges,
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 55.07% 56.40% +1.33%
==========================================
Files 12 12
Lines 345 367 +22
==========================================
+ Hits 190 207 +17
- Misses 155 160 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@jdebacker. This looks great. Thanks for this. Merging as soon as tests pass. |
This PR makes the following enhancements:
Calibrate
class object which represent the date ranges for macro data. Update theget_macro_params
function to take these arguments.calibrate.py
: take out references to estimatingmacro_params.py
to better organized calls to different data sources