Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch setup configuration to to pyproject.toml #244

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

altheaden
Copy link
Collaborator

In this PR I've migrated the setup configuration from the older setup.py and setup.cfg procedure to a pyproject.toml approach. There is an additional configuration file for flake8 because flake8 doesn't support the pyproject.toml format.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@altheaden altheaden added ci Changes affect github actions CI deployment Changes relate to creating conda and Spack environments, and creating a load script labels Nov 8, 2024
@altheaden
Copy link
Collaborator Author

Testing

I ran the configure script with this command:

./configure_polaris_envs.py --conda ~/miniforge3/ --env_name polaris-test --verbose --recreate

and it worked as expected. Then, I loaded the environment via the load script and received this error:

Loading conda environment
Done.

Loading Spack environment...

Lmod is automatically replacing "gcc-native/12.3" with "gcc/12.2.0".


The following have been reloaded with a version change:
  1) gcc/12.2.0 => gcc/11.2.0


The following have been reloaded with a version change:
  1) craype/2.7.30 => craype/2.7.20

Lmod has detected the following error:  The following module(s) are unknown:
"libfabric/1.15.2.0"

Please check the spelling or version number. Also try "module spider ..."
It is also possible your cache file is out-of-date; it may help to try:
  $ module --ignore_cache load "libfabric/1.15.2.0"

Also make sure that all modulefiles written in TCL start with the string #%Module



Done.

I'm not sure if the error is due to this update, though, because I get the same error when I run the configure script and source the load script on main.

@xylar
Copy link
Collaborator

xylar commented Nov 9, 2024

No, unrelated to this and something we'll fix in the 0.5.0 version update.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @altheaden! I was able to run the configure script on Chrysalis, recreate my conda environment, and run polaris list.

@xylar xylar self-assigned this Nov 12, 2024
@xylar xylar merged commit 3d2f069 into E3SM-Project:main Nov 12, 2024
5 checks passed
@xylar xylar deleted the switch-to-pyproject branch November 12, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes affect github actions CI deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants