Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend manufactured solution to del2 and del4 #234

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cbegeman
Copy link
Collaborator

@cbegeman cbegeman commented Oct 1, 2024

This PR adds manufactured solution tests for del2 and del4 and renames the existing case to default. Both del2 and del4 tests depend on the corresponding source terms being added to the model. These terms are added to MPAS-Ocean here E3SM-Ocean-Discussion/E3SM#110. All tests depend on E3SM-Ocean-Discussion/E3SM#55 to achieve expected convergence.

Several parameter combinations of wavelength, viscosity, and horizontal resolution were tested and no combination was found to exercise del4 over a factor of 8 in resolution. Thus, del4 is included here with the same parameter options as del2 and default but it does not alter the convergence rate.

Checklist

@cbegeman cbegeman added ocean Related to ocean tests or analysis E3SM PR required The polaris changes won't work with the current E3SM-Project submodule and require an update Omega PR required The polaris changes won't work with the current Omega submodule and require an update labels Oct 1, 2024
@cbegeman cbegeman self-assigned this Oct 1, 2024
@cbegeman
Copy link
Collaborator Author

cbegeman commented Oct 1, 2024

Testing

MPAS-Ocean tests have been run with E3SM-Ocean-Discussion/E3SM#110 and E3SM-Ocean-Discussion/E3SM#55.
Default convergence:
image

Del2 convergence:
image

Omega tests have been set-up and namelist file examined to ensure it has the appropriate settings.

@cbegeman cbegeman requested review from xylar and sbrus89 October 1, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E3SM PR required The polaris changes won't work with the current E3SM-Project submodule and require an update ocean Related to ocean tests or analysis Omega PR required The polaris changes won't work with the current Omega submodule and require an update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant