Extend manufactured solution to del2 and del4 #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds manufactured solution tests for del2 and del4 and renames the existing case to
default
. Both del2 and del4 tests depend on the corresponding source terms being added to the model. These terms are added to MPAS-Ocean here E3SM-Ocean-Discussion/E3SM#110. All tests depend on E3SM-Ocean-Discussion/E3SM#55 to achieve expected convergence.Several parameter combinations of wavelength, viscosity, and horizontal resolution were tested and no combination was found to exercise del4 over a factor of 8 in resolution. Thus, del4 is included here with the same parameter options as del2 and default but it does not alter the convergence rate.
Checklist
Testing
comment in the PR documents testing used to verify the changes