Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit dependencies #230

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 27, 2024

This PR also adds monthly automatic updates.

Checklist

@xylar xylar added the ci Changes affect github actions CI label Sep 27, 2024
@xylar xylar self-assigned this Sep 27, 2024
@xylar
Copy link
Collaborator Author

xylar commented Sep 27, 2024

I ran into issues with flake8 and it took me awhile to realize it was because the version in pre-commit was pretty out of date. I'm hoping this fixes it.

@xylar
Copy link
Collaborator Author

xylar commented Sep 27, 2024

@altheaden, could you take a look at this as soon as you have time? We want to update pre-commit dependencies on other repos as well:

pre-commit autoupdate

and we probably want to add the monthly update like here.

Copy link
Collaborator

@altheaden altheaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, unless you would like me to do any testing in particular then I think this is fine.

@altheaden
Copy link
Collaborator

@xylar I thought this is the sort of thing the dependabot would auto-update, does it not look at this file?

@xylar
Copy link
Collaborator Author

xylar commented Sep 30, 2024

@altheaden, I looked into this and it looks like dependabot can't handle pre-commit:
dependabot/dependabot-core#1524

@xylar xylar merged commit 563b1f8 into E3SM-Project:main Sep 30, 2024
5 checks passed
@xylar xylar deleted the update-pre-commit-deps branch September 30, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes affect github actions CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants