Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove polaris clean from check polaris commands #217

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

altheaden
Copy link
Collaborator

check_env() fails when trying to run polaris clean because it's a deprecated command. I just removed this call from the check.

Checklist

  • Testing comment in the PR documents testing used to verify the changes

@altheaden altheaden added bug Something isn't working deployment Changes relate to creating conda and Spack environments, and creating a load script labels Aug 6, 2024
@altheaden
Copy link
Collaborator Author

Testing

I ran this to create an environment with --check and it worked, where it had been previously failing.

@altheaden altheaden requested a review from xylar August 6, 2024 19:31
@altheaden altheaden mentioned this pull request Aug 6, 2024
1 task
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, we don't have that command!

@xylar xylar self-assigned this Aug 6, 2024
@xylar xylar merged commit 1f0c36c into E3SM-Project:main Aug 7, 2024
4 checks passed
@xylar xylar deleted the check-env-fix branch August 7, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment Changes relate to creating conda and Spack environments, and creating a load script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants