Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set permissions for Omega CTest downloads #199

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 11, 2024

Without this, the files are being left with permissions such that only the person downloading the file can read them.

To support this, we move code for updating permissions to the shared io module

Checklist

  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.md) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • Testing comment in the PR documents testing used to verify the changes

fixes #198

This code will also be needed in the Omega CTest utility.
Without this, the files are being left with permissions such that
only the person downloading the file can read them.
@xylar xylar added bug Something isn't working clean-up utility Utility script(s) in the utils directory labels Jul 11, 2024
@xylar xylar self-assigned this Jul 11, 2024
@xylar
Copy link
Collaborator Author

xylar commented Jul 12, 2024

@sbrus89, could you delete the following directory on Perlmutter?

/global/cfs/cdirs/e3sm/polaris/ocean/broken_omega_ctest

I had to move it aside because only you can access it because of the bug that this PR aims to fix.

@xylar
Copy link
Collaborator Author

xylar commented Jul 12, 2024

Testing

I ran the Omega CTests on Perlmutter-CPU with Gnu. I removed the omega_ctest shared directory so that files were re-downloaded. As expected, the permissions were set to:

xylar@perlmutter:login25:/global/cfs/cdirs/e3sm/polaris/ocean> ls -lah omega_ctest/
total 86M
drwxrwxr-x 2 xylar e3sm 4.0K Jul 12 01:56 .
drwxrwxr-x 5 xylar e3sm 4.0K Jul 12 01:56 ..
-rw-rw-r-- 1 xylar e3sm 3.6M Jul 12 01:56 cosine_bell_icos480_initial_state.230220.nc
-rw-rw-r-- 1 xylar e3sm  80M Jul 12 01:56 ocean.QU.240km.151209.nc
-rw-rw-r-- 1 xylar e3sm 2.5M Jul 12 01:56 PlanarPeriodic48x48.nc

@xylar xylar merged commit a87a3a4 into E3SM-Project:main Jul 12, 2024
4 checks passed
@xylar xylar deleted the fix-permissions-from-omega-ctest branch July 12, 2024 09:12
@sbrus89
Copy link
Contributor

sbrus89 commented Jul 15, 2024

@sbrus89, could you delete the following directory on Perlmutter?

/global/cfs/cdirs/e3sm/polaris/ocean/broken_omega_ctest

I had to move it aside because only you can access it because of the bug that this PR aims to fix.

Just took care of this @xylar, thanks for letting me know.

@xylar
Copy link
Collaborator Author

xylar commented Jul 15, 2024

@sbrus89, great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clean-up utility Utility script(s) in the utils directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Omega CTest utility not setting file permissions correctly
2 participants