Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch the mesh used for Omega CTests #190

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Mar 15, 2024

This merge updates the mesh used in Omega's CTests to an oQU240 initial condition taken from inputdata on the E3SM server. This is necessary for the HORZMESH_TEST to pass, since that test assumes realistic total ocean area and coriolis parameter.

This merge also updates the Omega submodule to the latest develop (hash: ca19fa9)

Checklist

  • Testing comment in the PR documents testing used to verify the changes

This is necessary for the HORZMESH_TEST to pass
@xylar xylar added utility Utility script(s) in the utils directory Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished labels Mar 15, 2024
@xylar xylar requested a review from sbrus89 March 15, 2024 11:01
@xylar xylar self-assigned this Mar 15, 2024
@xylar
Copy link
Collaborator Author

xylar commented Mar 15, 2024

Testing

I was able to successfully run Omega's CTests with these updates, whereas the HORZMESH_TEST was failing with the previous (Icos480 cosine-bell) horizontal mesh.

@xylar
Copy link
Collaborator Author

xylar commented Mar 15, 2024

@sbrus89, could you have a look at this when you have time?

@xylar
Copy link
Collaborator Author

xylar commented Mar 26, 2024

@sbrus89, still hoping you can have a look at this at some point.

@sbrus89
Copy link
Contributor

sbrus89 commented Mar 27, 2024

Sorry @xlyar, I lost track of this. I'll finish reviewing tomorrow.

Copy link
Contributor

@sbrus89 sbrus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on successful testing on pm-cpu. Thanks for this fix, @xylar.

@xylar
Copy link
Collaborator Author

xylar commented Mar 28, 2024

Thanks, @sbrus89!

@xylar xylar merged commit 4fc0610 into E3SM-Project:main Mar 28, 2024
4 checks passed
@xylar xylar deleted the fix-mesh-for-omega-ctests branch July 15, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Omega PR finished The polaris changes required an update to the Omega submodule and this is now finished utility Utility script(s) in the utils directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants