number of ghost layers needs to be set for bilinear maps #6851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need a new version of moab master, anyway
|
vijaysm
reviewed
Dec 15, 2024
| ! for bilinear maps, we need to have a layer of ghosts on source | ||
| nghlay = 1 ! number of ghost layers | ||
| ierr = iMOAB_SetGhostLayers( mbaxid, nghlay ) | ||
| if (ierr .ne. 0) then |
There was a problem hiding this comment.
I haven't tested an app that computes both conservative and bilinear in the same instance, when bilinear requires a ghost layer. Did you verify that conservative maps then remain the same? They should since we are adding more information to the mesh but I want to ensure the ghosted elements don't get counted twice. @iulian787
The change itself looks fine to, pending MOAB changes to get the functionality working correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is needed to setup the bilinear maps correctly; different PE layouts should result in the same map