Set default config_check_ssh_consistency for oQU240wLI to false #6746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing with ERS_Ld5.TL319_oQU240wLI_ais8to30.MPAS_LISIO_JRA1p5.chrysalis_intel.mpaso-ocn_glcshelf shows that the results are not changed by this PR, but the log.ocean.XXXX.err files are no longer produced |
|
jonbob
added a commit
that referenced
this pull request
Nov 13, 2024
Set default config_check_ssh_consistency for oQU240wLI to false Change the default config_check_ssh_consistency setting for oQU240wLI to false, to avoid confusing warnings/errors from tests with this grid. Otherwise we end up with log.ocean.err files complaining about: ERROR: Warning: Sea surface height outside of acceptable range (20m). In general, mpaso sets config_check_ssh_consistency to false for grids with ice shelf cavities, but this one was missed. [NML] for configurations with oQU240wLI [BFB]
|
Passes:
merged to next |
|
merged to master and expected NML DIFFs blessed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the default config_check_ssh_consistency setting for oQU240wLI to false, to avoid confusing warnings/errors from tests with this grid. Otherwise we end up with log.ocean.err files complaining about:
"ERROR: Warning: Sea surface height outside of acceptable range (20m)."
In general, mpaso sets config_check_ssh_consistency to false for grids with ice shelf cavities, but this one was missed.
[NML] for configurations with oQU240wLI
[BFB]