Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bugs in CMix/KPP interface #6708

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vanroekel
Copy link
Contributor

Two parts of the KPP interface had bugs

  1. The computation of surface buoyancy forcing and friction velocity were incorrect. The surfaceBuoyancyForcing subtracted the wrong values from the heat fluxes from thickness fluxes. The surfaceFrictionVelocity had incorrect interpolation to centers, the interpolation itself was unneeded. MPAS was interpolating stress to edges (for momentum forcing, but interpolating back (instead of using coupler values) for mixing friction velocity.
  2. The KPP interface for matchBoth is fixed and the indexing is fixed for matching interior to boundary layer diffusivities.

@vanroekel
Copy link
Contributor Author

zppy results from a 50 year LR spinup B-case are here

https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.vanroekel/E3SMv3/20240918_kppTest_ne30pg2_icos30_anvil/

it includes mpas-analysis and e3sm-diags

the comparison run is

https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.wlin/E3SMv3/20231209.v3.LR.piControl-spinup.chrysalis/

Looking at the diags, the changes to the climate are minor. Some degradation in bias (e.g. N. Atlantic temperature/salinity near surface), some improvement (e.g., drake passage transport).

@vanroekel
Copy link
Contributor Author

Further discussion and testing is here - E3SM-Ocean-Discussion#107

@rljacob rljacob requested a review from bpbond October 24, 2024 15:47
@bpbond
Copy link

bpbond commented Oct 24, 2024

Tagging @njeffery for her disciplinary expertise here 🙏

@bpbond bpbond requested a review from njeffery October 24, 2024 15:48
Copy link
Contributor

@njeffery njeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on review of mpas-analysis changes to sea ice and ocean metrics. After 50 years, changes are minor.

Copy link
Contributor

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of code inspection, idealized testing in E3SM-Ocean-Discussion#107, and B-case results showing that the results do not degrade climate.

@rljacob
Copy link
Member

rljacob commented Nov 21, 2024

@maltrud or @mark-petersen please review.

Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on simulations and visual inspection of code changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants