-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes bugs in CMix/KPP interface #6708
base: master
Are you sure you want to change the base?
Fixes bugs in CMix/KPP interface #6708
Conversation
zppy results from a 50 year LR spinup B-case are here it includes mpas-analysis and e3sm-diags the comparison run is Looking at the diags, the changes to the climate are minor. Some degradation in bias (e.g. N. Atlantic temperature/salinity near surface), some improvement (e.g., drake passage transport). |
Further discussion and testing is here - E3SM-Ocean-Discussion#107 |
Tagging @njeffery for her disciplinary expertise here 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on review of mpas-analysis changes to sea ice and ocean metrics. After 50 years, changes are minor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis of code inspection, idealized testing in E3SM-Ocean-Discussion#107, and B-case results showing that the results do not degrade climate.
@maltrud or @mark-petersen please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on simulations and visual inspection of code changes.
Two parts of the KPP interface had bugs