Introduce land ice surface mass balance fields in default runs without MECs/GLC #6682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ELM/GLC SMB QICE fields - makes QICE fields in h0 by default
changes should be b4b and just add additional SMB output of what would be passed to mali if we had an active GLC
do not change h2o mass balance
rljacob
requested review from
matthewhoffman
and removed request for
bishtgautam
|
@matthewhoffman please review. |
matthewhoffman
requested changes
Nov 15, 2024
There was a problem hiding this comment.
@chloewhicker , thanks for this PR, and sorry for the delay in reviewing it. I'm not familiar with this code, but I followed that you are mirroring the qflx_glcice calculations with new _diag versions of the relevant variables, and that all makes sense. I requested a number of code formatting/whitespace changes to make it clearer what the PR is actually doing.
|
Thanks for the feedback Matt - all comments have been addressed in the new commit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new diagnostic Surface Mass Balance fields, they are calculated as if there is a coupled land ice component but are only diagnostic - it does not modify the energy/water budgets in default or coupled GLC simulations.
More info on modifications and testing can be found here
[BFB]