add guide for code changes needed to support a new grid #6661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@brhillman please review |
1 similar comment
|
@brhillman please review |
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Outdated
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Outdated
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Outdated
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Outdated
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Outdated
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Outdated
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Outdated
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Outdated
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Outdated
Show resolved
Hide resolved
brhillman
reviewed
Oct 17, 2024
docs/dev-guide/adding-grid-support/adding-grid-support-step-by-step-guide/add-grid-config.md
Outdated
Show resolved
Hide resolved
added 3 commits
October 17, 2024 12:11
bishtgautam
reviewed
Nov 13, 2024
| valid_values= | ||
| "512x1024,360x720cru,128x256,64x128,..."> | ||
| Horizontal resolutions | ||
| Note: 0.1x0.1, 0.5x0.5, 5x5min, 10x10min, 3x3min and 0.33x0.33 are only used for CLM tools |
There was a problem hiding this comment.
@whannah1 Could you please change CLM to ELM even though the components/elm/bld/namelist_files/namelist_definition.xml has CLM? Thanks.
There was a problem hiding this comment.
done - but note that "CLM" still appears in the file that I'm referencing here:
https://github.com/E3SM-Project/E3SM/blob/master/components/elm/bld/namelist_files/namelist_definition.xml
Reorg some content and clarify ELM, EAM and CIME
|
Finally got around to making some changes I wanted. |
Thanks @rljacob ! Changes look good. |
rljacob
added a commit
that referenced
this pull request
Nov 15, 2024
This fills in a pre-existing page in the guide for supporting new grids, which provides various guidelines for the source code modifications needed for running with a new grid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fills in a pre-existing page in the guide for supporting new grids, which provides various
guidelines for the source code modifications needed for running with a new grid.