Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative data stream control for SO2 species in ext_frc #6562

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

wlin7
Copy link
Contributor

@wlin7 wlin7 commented Aug 26, 2024

Made changes to allow SO2 species in ext_frc_specifier to have a separate
data stream control (e.g., type, cycle_yr) from that for the other species.
This is probably the simplest way to allow only volcanic SO2 to vary with time
while holding all other SO2 sectors to a fixed year in historical single forcing
experiment design.

[BFB] for existing tests.

Copy link

github-actions bot commented Aug 26, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6562/
on branch gh-pages at 2024-08-29 03:27 UTC

Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config looks good. I am not following the need for the new tracer_data.F90 file. It's identical to the one already existing (and presumably was being used by this code).

git diff components/eam/src/chemistry/utils/tracer_data.F90 components/eam/src/chemistry/mozart/tracer_data.F90

@rljacob
Copy link
Member

rljacob commented Aug 27, 2024

Why does github think its a new file if its the same name in the same directory?

@mahf708
Copy link
Contributor

mahf708 commented Aug 27, 2024

Why does github think its a new file if its the same name in the same directory?

They are two different files... sorry I had the wrong code block above:

components/eam/src/chemistry/utils/tracer_data.F90 
components/eam/src/chemistry/mozart/tracer_data.F90

@wlin7
Copy link
Contributor Author

wlin7 commented Aug 29, 2024

Thanks for reviewing @mahf708 . I put the modified tracer_data.F90 on a wrong directory.
No essential change to the file. Just to print an extra variable (datatimep) to track (and verify) the correct data slice is read. The file was copied there after my test runs, so I didn't realize.

@wlin7 wlin7 requested a review from jinboxie August 29, 2024 03:31
@wlin7 wlin7 changed the title Add alternative data stream control for SO2 species in ect_frc Add alternative data stream control for SO2 species in ext_frc Aug 30, 2024
@rljacob
Copy link
Member

rljacob commented Sep 3, 2024

@jinboxie please review.

wlin7 added a commit that referenced this pull request Sep 4, 2024
Add alternative data stream control for SO2 species in ext_frc

Made changes to allow SO2 species in ext_frc_specifier to have a separate
data stream control (e.g., type, cycle_yr) from that for the other species.
This is probably the simplest way to allow only volcanic SO2 to vary with time
while holding all other SO2 sectors to a fixed year in historical single forcing
experiment design.

[BFB] for existing tests.
@wlin7 wlin7 merged commit 4670e29 into master Sep 5, 2024
21 checks passed
@wlin7 wlin7 deleted the wlin/atm/set_volc_stream_params branch September 5, 2024 18:57
@wlin7
Copy link
Contributor Author

wlin7 commented Sep 5, 2024

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants