Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ALCF Sunspot and Aurora machine configs #6553

Merged
merged 14 commits into from
Sep 6, 2024

Conversation

amametjanov
Copy link
Member

@amametjanov amametjanov commented Aug 16, 2024

Update ALCF Sunspot and Aurora machine configs.

[BFB]

@amametjanov amametjanov added Machine Files BFB PR leaves answers BFB labels Aug 16, 2024
@amametjanov amametjanov self-assigned this Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6553/
on branch gh-pages at 2024-08-31 02:24 UTC

@oksanaguba
Copy link
Contributor

i was tagged to review this. i have no opinion regarding these modules (but removed ones seem not to be used in scream configs). Maybe, it is useful to list what cases you were able to build/run with which compilers for this change?

Copy link
Collaborator

@omarkahmed omarkahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amametjanov , is there a specific reason why you are using the older software stack? The latest available module on sunspot is oneapi/eng-compiler/2024.04.15.002

@amametjanov
Copy link
Member Author

Yes, just a draft to get basics working. I'm testing oneapi/eng-compiler/2024.04.15.002 and will ping for (re-) review. Thanks.

@rljacob
Copy link
Member

rljacob commented Aug 16, 2024

@mahf708 the CI testing is running even though this a draft PR. Can we change that?

@xylar
Copy link
Contributor

xylar commented Aug 16, 2024

I don't think there's a way to prevent CI from draft PRs. At least I've never seen it.

@mahf708
Copy link
Contributor

mahf708 commented Aug 16, 2024

@mahf708 the CI testing is running even though this a draft PR. Can we change that?

Yes We Can

@xylar, I think specifying the type will do, but like you, I have never seen it or used it... https://github.com/orgs/community/discussions/25722#discussioncomment-5281953

Or we can apparently query the draftness: https://stackoverflow.com/a/68349262/22990681.

@mahf708
Copy link
Contributor

mahf708 commented Aug 16, 2024

@rljacob: I think we may want to move to labels-based testing (especially if we implement the self-hosted solution). (@xylar, for reference, https://github.com/mahf708/test-gh-runner-chrys/actions/runs/10409947659 ran on a chrysalis login node)

@xylar
Copy link
Contributor

xylar commented Aug 16, 2024

Good to know!

@amametjanov
Copy link
Member Author

amametjanov commented Aug 19, 2024

Testing on Sunspot:

@omarkahmed
Copy link
Collaborator

omarkahmed commented Aug 20, 2024

@amametjanov , did you run this branch with oneapi-ifxgpu ?

To clarify, I think there need to be a few small patches in order for i.e. F2010-MMF1 to run on oneapi-ifxgpu. However, I wanted to confirm whether this would be important for the scope of this PR?

Also export ZES_ENABLE_SYSMAN=1 to avoid ext_intel_free_memory
run-time errors.
Also avoid a call to variadic printf in a SYCL kernel within
an error diagnostic log.
Copy link
Collaborator

@omarkahmed omarkahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amametjanov , your changes look good to me.

I would suggest considering the following changes to the oneapi-ifxgpu config:

<MAX_MPITASKS_PER_NODE compiler="oneapi-ifxgpu">48</MAX_MPITASKS_PER_NODE>
<env name="ZEX_NUMBER_OF_CCS">0:4,1:4,2:4,3:4:4:4,5:4,6:4,7:4</env>

This would allow you to run in "4-CCS mode", where you can use 4 MPI ranks per PVC tile with minimal performance differences on the device side (assuming that work is balanced between ranks), but significant speed-up on the host due to the increased number of processes.

@amametjanov amametjanov marked this pull request as ready for review August 28, 2024 20:55
@amametjanov amametjanov changed the title Update ALCF Sunspot machine config Update ALCF Sunspot and Aurora machine configs Aug 30, 2024
Copy link
Collaborator

@omarkahmed omarkahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amametjanov , I am seeing some errors on your branch running on aurora with multiple openmp threads. Removing the "--cpu-bind depth" option to mpiexec appears to resolve things. Otherwise, things are looking great!

I wanted to note that I will be on bonding leave over the next two months, so my participation during this period will be sporadic starting on Monday.

@rljacob
Copy link
Member

rljacob commented Sep 5, 2024

Notes: Aurora currently down for network upgrade. Will wait for it to come back up and test again.

amametjanov added a commit that referenced this pull request Sep 6, 2024
Update ALCF Sunspot and Aurora machine configs.

[BFB]
@amametjanov amametjanov merged commit 0ce7fcf into master Sep 6, 2024
21 checks passed
@amametjanov amametjanov deleted the azamat/machines/sunspot20240816 branch September 6, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aurora BFB PR leaves answers BFB Machine Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants