Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hommexx: fix templating #6449

Closed
wants to merge 2 commits into from
Closed

hommexx: fix templating #6449

wants to merge 2 commits into from

Conversation

oksanaguba
Copy link
Contributor

@oksanaguba oksanaguba commented May 28, 2024 •
edited
Loading

minor fix for column ops for BFB runs on gpu.

adding hops cache files.

@oksanaguba oksanaguba self-assigned this May 28, 2024
@github-actions GitHub Actions
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6449/
on branch gh-pages at 2024-05-28 21:20 UTC

@rljacob rljacob added the HOMME label May 31, 2024
@rljacob
Copy link
Member

rljacob commented Jun 27, 2024

@oksanaguba status update?

@oksanaguba
Copy link
Contributor Author

will merge next week

@oksanaguba
Copy link
Contributor Author

i forgot about this PR, but will merge it in a few days.

@oksanaguba oksanaguba changed the title [wip] hommexx: fix templating hommexx: fix templating Jul 25, 2024
@rljacob
Copy link
Member

rljacob commented Aug 15, 2024

Notes: Depends on a @trey-ornl PR. May not be needed.

@rljacob rljacob requested a review from trey-ornl August 27, 2024 03:08
trey-ornl
trey-ornl reviewed Aug 27, 2024
View reviewed changes
components/homme/src/share/cxx/ExecSpaceDefs.hpp
< Kokkos::Impl::FunctorPatternInterface::SCAN
, void
, Lambda, void >::value_type ;
#else
using value_type =
typename Kokkos::Impl::FunctorAnalysis
< Kokkos::Impl::FunctorPatternInterface::SCAN
, void
, Lambda >::value_type ;
Copy link
Contributor

@trey-ornl trey-ornl Aug 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So adding the extra void template argument doesn't work for the non-GPU case, thus requiring the #ifdef?

@trey-ornl
Copy link
Contributor

trey-ornl commented Aug 27, 2024 •
edited
Loading

Notes: Depends on a @trey-ornl PR. May not be needed.

I'm happy to review, but I don't recall the dependent PR. @rljacob, which one is it?

@oksanaguba
Copy link
Contributor Author

@trey-ornl -- i do not remember. i think this PR is in a conflict with your CAAR PR, so it is not relevant. i can even close it.

@trey-ornl
Copy link
Contributor

@trey-ornl -- i do not remember. i think this PR is in a conflict with your CAAR PR, so it is not relevant. i can even close it.

This one has changes to ExecSpaceDefs.cpp but not ExecSpaceDefs.hpp. I think they're unrelated.

@oksanaguba
Copy link
Contributor Author

i dont have time testing this, so let's close for now.

@oksanaguba oksanaguba closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trey-ornl trey-ornl trey-ornl left review comments

Assignees

@oksanaguba oksanaguba

Labels
HOMME
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oksanaguba @rljacob @trey-ornl