Jgfouca/scream downstream 04 11 24 #6343
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,5 @@ updates: | |
| reviewers: | ||
| - "mahf708" | ||
| - "bartgol" | ||
| labels: | ||
| - "AT: Integrate Without Testing" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: inputdata | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] | ||
| pull_request: | ||
| branches: [ master ] | ||
| schedule: | ||
| - cron: '00 00 * * *' | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| scream-defaults: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| event_name: ${{ github.event_name }} | ||
| steps: | ||
| - name: Check out the repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| show-progress: false | ||
| submodules: false | ||
| - name: Set up Python 3.11 | ||
| uses: actions/[email protected] | ||
| with: | ||
| python-version: "3.11" | ||
| - name: Run unit tests | ||
| working-directory: components/eamxx/cime_config/ | ||
| run: | | ||
| python -m unittest tests/eamxx_default_files.py -v | ||
|
|
||
| notify-scream-defaults: | ||
| needs: scream-defaults | ||
| if: ${{ failure() && needs.scream-defaults.outputs.event_name != 'pull_request' }} | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Create issue | ||
| run: | | ||
| previous_issue_number=$(gh issue list \ | ||
| --label "$LABELS" \ | ||
| --json number \ | ||
| --jq '.[0].number') | ||
| if [[ -n $previous_issue_number ]]; then | ||
| gh issue comment "$previous_issue_number" \ | ||
| --body "$BODY" | ||
| else | ||
| gh issue create \ | ||
| --title "$TITLE" \ | ||
| --assignee "$ASSIGNEES" \ | ||
| --label "$LABELS" \ | ||
| --body "$BODY" | ||
| fi | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GH_REPO: ${{ github.repository }} | ||
| TITLE: Inputdata server file missing | ||
| ASSIGNEES: mahf708,bartgol | ||
| LABELS: bug,input file,notify-file-gh-action | ||
| BODY: | | ||
| Workflow failed! There's likely a missing file specified in the configs! For more information, please see: | ||
| - Workflow URL: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }} (number ${{ github.run_number }}, attempt ${{ github.run_attempt }}) | ||
| - Workflow SHA: ${{ github.sha }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4480,6 +4480,11 @@ | |
| <map name="ROF2LND_FMAPNAME">lnd/clm2/mappingdata/maps/ne240np4/map_0.1x0.1_nomask_to_ne240np4_nomask_aave_da_c120706.nc</map> | ||
| </gridmap> | ||
|
|
||
| <gridmap lnd_grid="ne256np4.pg2" rof_grid="r0125"> | ||
| <map name="LND2ROF_FMAPNAME">cpl/gridmaps/ne256pg2/map_ne256pg2_to_r0125_mono.200212.nc</map> | ||
| <map name="ROF2LND_FMAPNAME">cpl/gridmaps/ne256pg2/map_r0125_to_ne256pg2_mono.200212.nc</map> | ||
|
There was a problem hiding this comment. "mono" is no longer a valid key in a map name. There was a problem hiding this comment. @brhillman , can you chime in here? Looks like you added this on the eamxx side with this commit: There was a problem hiding this comment. @rljacob what are we calling the conservative monotonic tempest remap algorithm now? There was a problem hiding this comment. Its traave since its a pg2 grid. There was a problem hiding this comment. @brhillman , @rljacob , so should this be changed to: |
||
| </gridmap> | ||
|
|
||
| <gridmap lnd_grid="ne1024np4.pg2" rof_grid="r0125"> | ||
| <map name="LND2ROF_FMAPNAME">cpl/gridmaps/ne1024pg2/map_ne1024pg2_to_r0125_mono.200212.nc</map> | ||
| <map name="ROF2LND_FMAPNAME">cpl/gridmaps/ne1024pg2/map_r0125_to_ne1024pg2_mono.200212.nc</map> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -585,8 +585,8 @@ subroutine stepon_run3(dtime, cam_out, phys_state, dyn_in, dyn_out) | |
| if (dp_crm) then | ||
|
|
||
| do ie=1,nelemd | ||
| out_gridx(:,:) = dyn_in%elem(ie)%spherep(:,:)%lon | ||
|
There was a problem hiding this comment. This looks like it fixed a bug. There was a problem hiding this comment. Yep: I've updated the description. |
||
| out_gridy(:,:) = dyn_in%elem(ie)%spherep(:,:)%lat | ||
| call outfld('crm_grid_x', out_gridx, npsq, ie) | ||
| call outfld('crm_grid_y', out_gridy, npsq, ie) | ||
| enddo | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahf708
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it checks that certain inputs are downloaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's right. It checkes that eamxx default files in the xml are actually present on the server, and if they are not present, it will open an issue. It runs periodically behind the scenes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can disable it for now if this is an issue (or have it run only on the scream side downstream).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be harmless for E3SM, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it is harmless. In fact, it should be a good addition (early notification for server/user errors). It won't try to figure out what's wrong with E3SM inputfiles at all, but we can extend that later if desired.