Update LULC file for v3 historical compset #6339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@bishtgautam please review. |
bishtgautam
approved these changes
May 4, 2024
|
I moved the following @wlin7's notes from the first comment to here because the first comment
|
|
That note is important enough to be in the commit message. PR description edited. |
|
@bishtgautam you can start merging this |
bbye
approved these changes
May 14, 2024
|
@bishtgautam any reason not to merge this? |
|
Sorry for being late on merging this. This is ready to go. |
|
@bishtgautam please start merging it. |
bishtgautam
added a commit
that referenced
this pull request
May 29, 2024
The is to replace the old r05 landuse.timeseries file for the historical compsets (e.g., F20TR and WCYCL20TR), which is considered outdated (probably using CMIP5 raw data). This was noticed after the creation of v3.0.0 tag and before the start of v3.LR.historical simulations. The updated file is currently specified in the run script to override the default. [non-BFB] for F20TR and WCYCL20TR tests [NML] same as above for variable flanduse_timeseries
|
merged to next. |
|
@wlin7 can you create an issue for this since it was a bug in 3.0.0 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is to replace the old r05 landuse.timeseries file for the historical compsets
(e.g., F20TR and WCYCL20TR), which is considered outdated (probably using CMIP5 raw data).
This was noticed after the creation of v3.0.0 tag and before the start of v3.LR.historical simulations.
The updated file is currently specified in the run script to override the default.
[non-BFB] for F20TR and WCYCL20TR tests
[NML] same as above for variable flanduse_timeseries