Self-attraction-and-loading and harmonic analysis for SSH != 0 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include pressure forcing term in SAL computation to account for under isc and atm pressure cases. - Update SAL coastal smoothing factor to mask shallow cells where wet-dry effects may occur out of SAL computation. - Compute harmonic analysis AM wrt. SSH-SSH_init to account for initially non-zero SSH distributions.
- Add missing rho0gInv definition.
sbrus89
reviewed
Apr 25, 2023
There was a problem hiding this comment.
@dengwirda, thanks for making the modifications! I just left a few minor comments to possibly consider as well.
components/mpas-ocean/src/analysis_members/Registry_harmonic_analysis.xml
Outdated
Show resolved
Hide resolved
components/mpas-ocean/src/mode_forward/mpas_ocn_time_integration_split.F
Outdated
Show resolved
Hide resolved
components/mpas-ocean/src/mode_forward/mpas_ocn_time_integration_si.F
Outdated
Show resolved
Hide resolved
components/mpas-ocean/src/shared/mpas_ocn_vel_self_attraction_loading.F
Outdated
Show resolved
Hide resolved
- Clean up descriptions, comments and use real-valued switches.
- Change sshSmoothed to btrPressure in SAL routines, since we're now working with surface pressures too.
|
Thanks @sbrus89, I've updated to include those suggestions. |
mark-petersen
approved these changes
May 3, 2023
| allocate(sshDiff(nCellsSolve)) | ||
|
|
||
| do iCell = 1,nCellsSolve | ||
| sshDiff(iCell) = ssh(iCell) - sshInit(iCell) |
There was a problem hiding this comment.
Just to point it out, this is the substantial line of this PR.
| sshSmoothed(iCell) = coastalSmoothingFactor(iCell)*ssh(iCell) | ||
| ! compute SAL wrt. the full barotropic bottom pressure | ||
| btrPressure(iCell) = coastalSmoothingFactor(iCell) * ( & | ||
| ssh(iCell) + rho0gInv * surfacePressure(iCell) ) |
| do iCell = 1,nCellsAll | ||
| depth = ssh(iCell) + bottomDepth(iCell) | ||
| coastalSmoothingFactor(iCell) = 0.5_RKIND*(tanh( & | ||
| (depth - 0.5_RKIND*depth_tol) / (0.2_RKIND*depth_tol)) + 1.0_RKIND) |
There was a problem hiding this comment.
Change to coastal smoothing factor to be depth-based rather than width-based.
sbrus89
approved these changes
May 9, 2023
There was a problem hiding this comment.
@dengwirda, thanks for making those changes. This looks ready to be moved to an E3SM PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses three issues encountered in tides runs with non-zero initial sea-surface heights (due to either ice-shelf cavities and/or dry cells adjacent to the coast):
ssh_salvariable(s) have been renamedpgf_salsince there's now the full barotropic pressure dependence rather than just SSH.coastalSmoothingFactorused in the SAL computation is updated to use a depth threshold, allowing very thin, dry cells to be effectively masked out of the computation. This prevents spurious SAL tendencies being computed near the coast, where dry cells on land (with effectively a raised SSH value) would previously contaminate the SAL computed on adjacent wet cells. The depth threshold is controlled using theconfig_self_attraction_loading_depth_cutoffoption, with SSH smoothing applied to columns of lesser thickness, which controls SAL behaviour near the wet-dry interface.Tested with the ICoM 45to5km tides mesh, cori-haswell + pm-cpu and gnu.