Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate removal of Antarctic river and ice runoff #103

Closed
wants to merge 3 commits into from
Closed

Separate removal of Antarctic river and ice runoff #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
914225e
Remove trailing whitespace
xylar Jun 23, 2024
a592f83
Remove totalRemoved*RunoffFlux variables
xylar Jun 23, 2024
5cb37fb
Separate removal of Antarctic river and ice runoff
xylar Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions components/mpas-ocean/bld/build-namelist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,10 +707,11 @@ add_default($nl, 'config_flux_attenuation_coefficient_runoff');
# Namelist group: coupling #
############################

add_default($nl, 'config_remove_ais_river_runoff');
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a non-BFB change for simulations with DIB. @darincomeau and @cbegeman, do you agree that we no longer want to remove river runoff? Or should we make this change a separate PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we mostly likely want to make this change, but I'd like to see a 30-year B-case before deciding to make this the default.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that will be a lot to be able to afford for a SORRM run just to test this config option, but we can discuss it.

if (($OCN_ICEBERG eq 'true') && ($OCN_FORCING eq 'active_atm')) {
add_default($nl, 'config_remove_AIS_coupler_runoff', 'val'=>".true.");
add_default($nl, 'config_remove_ais_ice_runoff', 'val'=>".true.");
} else {
add_default($nl, 'config_remove_AIS_coupler_runoff', 'val'=>".false.");
add_default($nl, 'config_remove_ais_ice_runoff', 'val'=>".false.");
}

######################################
Expand Down
3 changes: 2 additions & 1 deletion components/mpas-ocean/bld/build-namelist-section
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,8 @@ add_default($nl, 'config_flux_attenuation_coefficient_runoff');
# Namelist group: coupling #
############################

add_default($nl, 'config_remove_AIS_coupler_runoff');
add_default($nl, 'config_remove_ais_river_runoff');
add_default($nl, 'config_remove_ais_ice_runoff');

######################################
# Namelist group: shortwaveRadiation #
Expand Down
3 changes: 2 additions & 1 deletion components/mpas-ocean/bld/namelist_files/namelist_defaults_mpaso.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,8 @@
<config_flux_attenuation_coefficient_runoff>10.0</config_flux_attenuation_coefficient_runoff>

<!-- coupling -->
<config_remove_AIS_coupler_runoff>.false.</config_remove_AIS_coupler_runoff>
<config_remove_ais_river_runoff>.false.</config_remove_ais_river_runoff>
<config_remove_ais_ice_runoff>.false.</config_remove_ais_ice_runoff>

<!-- shortwaveRadiation -->
<config_sw_absorption_type>'jerlov'</config_sw_absorption_type>
Expand Down
12 changes: 10 additions & 2 deletions components/mpas-ocean/bld/namelist_files/namelist_definition_mpaso.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1191,9 +1191,17 @@ Default: Defined in namelist_defaults.xml

<!-- coupling -->

<entry id="config_remove_AIS_coupler_runoff" type="logical"
<entry id="config_remove_ais_river_runoff" type="logical"
category="coupling" group="coupling">
If true, solid and liquid runoff from the Antarctic Ice Sheet (below 60S latitude) coming from the coupled is zeroed in the coupler import routines. To be used with data iceberg fluxes coming from the sea ice model.
If true, liquid runoff from the Antarctic Ice Sheet (below 60S latitude) coming from the coupled is zeroed in the coupler import routines. To be used with data iceberg fluxes coming from the sea ice model.

Valid values: .true. or .false.
Default: Defined in namelist_defaults.xml
</entry>

<entry id="config_remove_ais_ice_runoff" type="logical"
category="coupling" group="coupling">
If true, solid runoff from the Antarctic Ice Sheet (below 60S latitude) coming from the coupled is zeroed in the coupler import routines. To be used with data iceberg fluxes coming from the sea ice model.

Valid values: .true. or .false.
Default: Defined in namelist_defaults.xml
Expand Down
Loading