feat: modified fit() function in cnn #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameerashahh
changed the title
carynbear
requested changes
Jul 22, 2024
src/dynadojo/baselines/cnn.py
Outdated
| # print(loss.item()) | ||
| loss.backward() | ||
| opt.step() | ||
| losses.append(loss) |
There was a problem hiding this comment.
Should append loss.item()
carynbear
approved these changes
Jul 22, 2024
carynbear
pushed a commit
that referenced
this pull request
Jul 22, 2024
…fit() (#98, #99, #100, #102) feat: return loss dict in dnn.fit() (#101) feat: return loss dict in dnn.fit() (#99) feat: return loss dict in cnn.fit() (#98) * modified fit function to return loss.item() modified fit function to return losses modified fit function to track training losses modified fit function to return loss added loss in fit function
lmclane04
pushed a commit
to lmclane04/dynadojo
that referenced
this pull request
Jul 26, 2024
…fit() (DynaDojo#98, DynaDojo#99, DynaDojo#100, DynaDojo#102) feat: return loss dict in dnn.fit() (DynaDojo#101) feat: return loss dict in dnn.fit() (DynaDojo#99) feat: return loss dict in cnn.fit() (DynaDojo#98) * modified fit function to return loss.item() modified fit function to return losses modified fit function to track training losses modified fit function to return loss added loss in fit function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the fit function to evaluate validation losses, and return both the training losses and validation losses.