Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in signature for SRConnectionStateChangedBlock #256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaurangtalwadkar
Copy link

Proposed Change

Changed signature for SRConnectionStateChangedBlock for passing oldState along with newState.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Delegate method specifies both oldState and newState when connection state changes. Similar change is done for the block.

Changed signature for SRConnectionStateChangedBlock for passing
oldState along with newState
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant