Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move grid generator to input section #559 #561

Conversation

aaananas
Copy link

@aaananas aaananas commented Jun 3, 2024

Fixes Issue

**My PR closes #559 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

Moved grid generator to input section

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
code-magic βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 3, 2024 10:36pm

@Dun-sin
Copy link
Owner

Dun-sin commented Jun 9, 2024

@aaananas this PR is incomplete, according to the Issue, it involved 2 tasks, moving the grid generator and fixing whatever bug occurs because of that movement.

You completed the act of moving the code for the grid generator, but the bug that occurred wasn't fixed.

The grid generator can no longer be accessed:
image

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the issue, i showed what lines should be moved and to where, click on the links in the issue description and you will be showed what I'm specifically talking about

@Dun-sin
Copy link
Owner

Dun-sin commented Jun 25, 2024

Looks like this PR isn't your priority anymore, will be closing it. Thanks for trying to contribute

@Dun-sin Dun-sin closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] move the grid generator input into the input section
2 participants