Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avoid gradient background results when single input is provided. #446

Closed
wants to merge 7 commits into from

Conversation

saakshiraut28
Copy link
Contributor

Fixes Issue

**My PR closes #430 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Do not show the result screen if only a single input is entered.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

The previous PR related to this issue was closed. Despite that, the Gradient background result screen was still visible even if the user entered only one input color. I have addressed this problem in this new PR.

πŸ“· Screenshots

codemagic4.mp4

@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
code-magic βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 30, 2023 7:51am

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 30, 2023

@saakshiraut28 i didn't say remove it, i just said use what we already have to get buttons in the getPackage.ts file instead of reinventing the wheel, if you do want to remove the code, i will just close the PR

@saakshiraut28
Copy link
Contributor Author

@Dun-sin, I think removing it would be better.

@Dun-sin Dun-sin closed this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] prevent getting results for gradient background if there is no input
2 participants