Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention that subject could get claims from server side sessions. #507

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

RolandGuijt
Copy link
Contributor

No description provided.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-507.eastus2.azurestaticapps.net

Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should incorporate this into the previous paragraph to make which claims you'll get more obvious. If server side sessions are on, we always use that. If they're off, then we give you different claims depending on the context.

@josephdecock
Copy link
Member

And maybe we can explain the the claims identity at the time of grant creation is stored in the grant store. So if you are in the profile service in the context of using a grant (exchanging a code for a token, etc), we can give you those claims, but if you are in the user info endpoint, we don't have anything except what is in the access token sent to the user info endpoint.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-507.eastus2.azurestaticapps.net

@RolandGuijt
Copy link
Contributor Author

@josephdecock I've used bullets now to create an if..then structure which should be more clear.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-507.eastus2.azurestaticapps.net

@RolandGuijt
Copy link
Contributor Author

RolandGuijt commented Aug 14, 2024

@josephdecock Agreed.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-507.eastus2.azurestaticapps.net

@RolandGuijt RolandGuijt merged commit 5967d62 into main Aug 14, 2024
2 checks passed
@RolandGuijt RolandGuijt deleted the roland/serversidesessionsmention branch August 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants