Copy editing for metrics.md #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-402.eastus2.azurestaticapps.net |
AndersAbel
requested changes
Jan 22, 2024
| for the UI. We do provide quick start UIs which are meant as a starting point for your own UI development. | ||
| In the quick start UIs we do provide metrics as a starting point, but you should alter and add metrics | ||
| as needed in your context. | ||
| The [UI in your IdentityServer host]({{< ref "/ui/" >}}) can instrument these events to measure |
There was a problem hiding this comment.
I wanted to point out that there are no counters in the IdentityServer Meter for UI related stuff. There is a different meter with counters in the UI template.
Also fix a couple spelling errors
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-402.eastus2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-402.eastus2.azurestaticapps.net |
AndersAbel
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected some minor nits on the metrics page, and clarified the subsection introductions.