Skip to content

Commit

Permalink
Fix review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
AndersAbel committed Mar 8, 2024
1 parent 3d5a490 commit 29855d9
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
21 changes: 11 additions & 10 deletions IdentityServer/v7/docs/content/diagnostics/otel/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,18 @@ telemetry data (metrics, logs, and traces). This is very useful for analyzing so
especially in highly distributed systems.

.NET 8 comes with first class support for Open Telemetry. IdentityServer emmits traces, metrics and logs.
- Metrics are high level statistic counters. They provide an aggregated overview and can be used to set monitoring rules.
- Traces shows individual requests and dependencies. The output is very useful for visualizing the control
flow and finding performance bottlenecks.
- Logs contains all the details when needed for troubleshooting.

{{%children style="h4" /%}}

Traces from a web application calling an API (displayed using Aspire). The web application uses a refresh token to call
IdentityServer to get a new access token and then calls the API. The API reads the discovery endpoint, finds the
jwsk url and then gets the keys from jwks endpoint.
![](images/aspire_traces.png)
#### [**Metrics**]({{< ref "metrics">}})
Metrics are high level statistic counters. They provide an aggregated overview and can be used to set monitoring rules.

#### **Logs**
OpenTelemetry in .NET 8 exports the logs written to the standard ILogger system. The logs are augmented with
trace ids to be able to correlate log entries with traces.

#### [**Traces**]({{< ref "traces">}})
Traces shows individual requests and dependencies. The output is very useful for visualizing the control
flow and finding performance bottlenecks.

This is an example of distributed traces from a web application calling an API (displayed using our
[Aspire sample]({{< ref "../../samples/diagnostics" >}})). The web application uses a refresh token to call IdentityServer to get a new access token and then calls the API. The API reads the discovery endpoint, finds the jwks url and then gets the keys from jwks endpoint.
![](images/aspire_traces.png)
2 changes: 1 addition & 1 deletion IdentityServer/v7/docs/content/samples/diagnostics.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ This sample is not intended to be a full Aspire sample, it simply uses Aspire as

IdentityServer emits OpenTelemetry traces for input validators, stores and response generators (see [here]({{< ref "/diagnostics/otel" >}}) for more information).

The samples shows how to setup Otel for console tracing.
The sample shows how to setup Otel for console tracing.

0 comments on commit 29855d9

Please sign in to comment.