Sourcery Starbot ⭐ refactored DucarrougeR/themis-1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SourceryAI
commented
Jun 19, 2021
Comment on lines
-22
to
+37
| if connection.name not in ('looker', 'looker__ilooker', 'looker__internal__analytics'): | ||
| if connection.dialect: | ||
| connection_tests = {'tests': connection.dialect.connection_tests} | ||
| for test in connection_tests['tests']: | ||
| try: | ||
| db_validation = self.looker_client.test_connection(connection.name, test) | ||
| for item in db_validation: | ||
| if item.status != 'success': | ||
| db_errors.append("Database Connection {} Test '{}' returned '{}'".format(connection.name, | ||
| item.name, | ||
| item.message)) | ||
| except Exception as e: | ||
| print("Database Connection test for {} failed due to {}".format(connection.name, e)) | ||
| if ( | ||
| connection.name | ||
| not in ('looker', 'looker__ilooker', 'looker__internal__analytics') | ||
| and connection.dialect | ||
| ): | ||
| connection_tests = {'tests': connection.dialect.connection_tests} | ||
| for test in connection_tests['tests']: | ||
| try: | ||
| db_validation = self.looker_client.test_connection(connection.name, test) | ||
| for item in db_validation: | ||
| if item.status != 'success': | ||
| db_errors.append("Database Connection {} Test '{}' returned '{}'".format(connection.name, | ||
| item.name, | ||
| item.message)) | ||
| except Exception as e: | ||
| print("Database Connection test for {} failed due to {}".format(connection.name, e)) |
There was a problem hiding this comment.
Function Connectivity.test_db_connections refactored with the following changes:
- Merge nested if conditions (
merge-nested-ifs)
Comment on lines
-56
to
-58
| else: | ||
| # integration_errors.append("Integration {} not enabled.".format(elem.label)) | ||
| pass |
There was a problem hiding this comment.
Function Connectivity.test_integrations refactored with the following changes:
- Remove redundant pass statement (
remove-redundant-pass)
This removes the following comments ( why? ):
# integration_errors.append("Integration {} not enabled.".format(elem.label))
modules/connectivity.py
Outdated
Comment on lines
67
to
74
| group_errors = [] | ||
| for elem in all_datagroups: | ||
| if elem.trigger_error: | ||
| group_errors.append("Datagroup \"{}\" on model \"{}\" has this error:\t{}".format(elem.name, | ||
| elem.model_name, | ||
| elem.trigger_error)) | ||
| return group_errors No newline at end of file | ||
| return [ | ||
| "Datagroup \"{}\" on model \"{}\" has this error:\t{}".format( | ||
| elem.name, elem.model_name, elem.trigger_error | ||
| ) | ||
| for elem in all_datagroups | ||
| if elem.trigger_error | ||
| ] |
There was a problem hiding this comment.
Function Connectivity.test_datagroups refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
| for i in range(0, len(error)): | ||
| for i in range(len(error)): |
There was a problem hiding this comment.
Function Content.validate_content refactored with the following changes:
- Replace range(0, x) with range(x) (
remove-zero-from-range)
| body = ''' | ||
| return ''' |
There was a problem hiding this comment.
Function email_body refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-59
to
+69
| cleaned_errors = [] | ||
| for elem in json.loads(failed_pdts_list): | ||
| # cleaned_errors.append("PDT \'{}\' failed with error: {}".format(elem['pdt_event_log.view_name'], elem['error_message'])) | ||
| cleaned_errors.append("PDT \'{}\' failed on connection: {}".format(elem['pdt_event_log.view_name'], elem['pdt_event_log.connection'])) | ||
| cleaned_errors = [ | ||
| "PDT \'{}\' failed on connection: {}".format( | ||
| elem['pdt_event_log.view_name'], elem['pdt_event_log.connection'] | ||
| ) | ||
| for elem in json.loads(failed_pdts_list) | ||
| ] | ||
|
|
There was a problem hiding this comment.
Function Schedules.get_pdts_status refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension)
This removes the following comments ( why? ):
# cleaned_errors.append("PDT \'{}\' failed with error: {}".format(elem['pdt_event_log.view_name'], elem['error_message']))
| to_emails = [] | ||
| for email in email_list.split(','): | ||
| to_emails.append(email) | ||
| to_emails = [email for email in email_list.split(',')] |
There was a problem hiding this comment.
Function send_report_out refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension)
Comment on lines
-25
to
+27
| disabled_users = [] | ||
| disabled_users = [i for i in all_users if i.is_disabled] | ||
|
|
||
| for i in all_users: | ||
| if i.is_disabled: | ||
| disabled_users.append(i) | ||
| user_results = [] | ||
| user_results.append("Disabled Looker users: {}".format(len(disabled_users))) | ||
| user_results = ["Disabled Looker users: {}".format(len(disabled_users))] |
There was a problem hiding this comment.
Function Users.get_users_issue refactored with the following changes:
- Merge append into list declaration (
merge-list-append) - Convert for loop into list comprehension (
list-comprehension)
Comment on lines
-16
to
+21
| cred_file = [] | ||
| for file in os.listdir(parent_dir): | ||
| if file.endswith(".ini"): | ||
| cred_file.append(os.path.join(parent_dir, file)) | ||
| cred_file = [ | ||
| os.path.join(parent_dir, file) | ||
| for file in os.listdir(parent_dir) | ||
| if file.endswith(".ini") | ||
| ] | ||
|
|
There was a problem hiding this comment.
Function LookerSDKTestCase.test_looker_credentials refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension)
Comment on lines
+33
to
-32
| regex = r'^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$' | ||
| for email in self.__class__.email_list.split(','): | ||
| regex = r'^\w+([\.-]?\w+)*@\w+([\.-]?\w+)*(\.\w{2,3})+$' |
There was a problem hiding this comment.
Function LookerSDKTestCase.test_emails_format refactored with the following changes:
- Hoist statements out of for/while loops (
hoist-statement-from-loop)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: