♻️ Enabled validation of nicknames, job titles, links, and images on the ProfileCard screen.

[Corvus400]

Issue

• close ProfileCard: validate nickname, occupation, link, and image #418

Overview (Required)

1. Added an input check function to the Edit screen
2. Added VRT for the added input check function
3. Added Fake implementation that was missing to implement VRT

Movie (Optional)

Before	After
before.mp4

[github-actions]

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

[github-actions]

Snapshot diff report

File name	Image
ProfileCardScreenTes t[ProfileCardScreen - when profile card is exists - it shoul d show card screen]_ compare.png
ProfileCardScreenTes t[ProfileCardScreen - when profile card is exists - when cli ck edit button - whe n if a required fiel d has not been fille d in - it should mak e sure the Create bu tton is deactivated] _compare.png
ProfileCardScreenTes t[ProfileCardScreen - when profile card is does not exists - it should show edit screen]_compare.png
ProfileCardScreenTes t[ProfileCardScreen - when profile card is exists - when cli ck edit button - it should show edit scr een]_compare.png
ProfileCardScreenTes t[ProfileCardScreen - when profile card is exists - when cli ck edit button - if all required fields are filled in - it s hould make sure the Create button is act ivated]_compare.png

[Corvus400]

This was added because it is necessary to prepare image data that can be decoded by FAKE in advance.
Of course, if there is a shorter string that can be decoded, we will replace it with it.🙏
This is a Base64 encoded version of the following image.

[takahirom]

Thanks. Could we create images by path or something similar? This base64 image makes code review difficult. I'm not sure if this would work, but could we create images like this?

@OptIn(ExperimentalEncodingApi::class)
fun drawCircleToBase64(size: IntSize = IntSize(100, 100)): String {
    val imageBitmap = ImageBitmap(size.width, size.height)
    val canvas = Canvas(imageBitmap)

    canvas.drawCircle(
        center = Offset(size.width / 2f, size.height / 2f),
        radius = size.width.coerceAtMost(size.height) / 2f,
        paint = Paint().apply {
            color = Color.Blue
            style = PaintingStyle.Fill
        }
    )

    val buffer = IntArray(size.width * size.height)
    imageBitmap.readPixels(buffer)
    val byteArray = when (imageBitmap.config) {
        ImageBitmapConfig.Argb8888 -> ByteArray(buffer.size) {
            buffer[it].toByte()
        }
        else -> throw UnsupportedOperationException("Unsupported image config: ${imageBitmap.config}")
    }

    return Base64.encode(byteArray)
}

[Corvus400]

@takahirom
If I use the code you suggested as is, the test does not proceed after 60 seconds time and seems to time out. 🤔
I will continue to look for a solution.

[Corvus400]

@takahirom
We have addressed this by adding a method to generate a Base64-encoded string of 400*400 white squares.
The reason we chose 400*400 is because the Twitter icon size is 400*400.

[takahirom]

Thanks. DataStore could be considered a 'how' aspect of the test. Therefore, I suggest naming it like this: setupSavedProfileCard(ProfileCardInputStatus.AllNotEntered)

[takahirom]

👍

[takahirom]

We don't need to change this in this PR, but my second thought on this is that we might be able to use DefaultProfileCardDataStore, and I think we can save the nickname or something similar when we call setupSavedProfileCard() as we can call suspend function. In this way, we can achieve high-fidelity tests.

[takahirom]

The issue is that this implementation could potentially conflict with this PR. Do you have any thoughts on this?
#459

[Corvus400]

@takahirom

Do you have any thoughts on this?

I see... 🤔
I was not aware of the content of that PR. 🙏
Since I should not have the authority to decide how to respond, I will leave it to you. 🫡
However, if I were to state this as an opinion, I believe that if I could be in charge of the task #112, it could be handled smoothly. 💪 (This is just an opinion)

[takahirom]

Well, we already have the PR, and we need to value the issue assignee to protect the opportunity for the contributor. Of course, we can't always protect it, though. So I think I might need to prioritize the other PR first. This might lead to a conflict. Sorry in advance.
#459

[Corvus400]

@takahirom
Conflicts have been resolved. 👍
In addition to resolving the conflict, we have made the display more similar to the requirements shown in Figma. 🫡

[takahirom]

I don't think we need to change this in this PR, but since tests can see the DataStore name, it would be better to use a more abstract name. However, it's fine for now.

[takahirom]

Well, I think this 'if the string is empty, show an error message' logic should be in the presenter.

[takahirom]

As you might know, I recommend small PRs because they can be merged quickly

[takahirom]

Thank you for your continuous efforts to improve our app!