Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Migrate AppStrings to compose multiplatform resources. #457

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Aug 14, 2024

Issue

Overview (Required)

  • All StringsBindings have been eliminated.

import io.github.droidkaigi.confsched.ui.UserMessageResult.ActionPerformed
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.catch
import kotlinx.coroutines.flow.retry

fun <T> Flow<T>.handleErrorAndRetry(
actionLabel: Strings<*>,
actionLabel: String,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is modified to be the same as here.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 14, 2024 17:21 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review August 14, 2024 17:46
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for your contribution!

@takahirom takahirom merged commit a14a752 into DroidKaigi:main Aug 15, 2024
9 checks passed
@Corvus400 Corvus400 deleted the enhancement/migrate_app_strings_to_compose_multiplatform_resources branch August 15, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate AppStrings to compose multiplatform resources
2 participants