Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS test action #455

Merged
merged 4 commits into from
Aug 16, 2024
Merged

iOS test action #455

merged 4 commits into from
Aug 16, 2024

Conversation

shin-usu
Copy link
Contributor

@shin-usu shin-usu commented Aug 14, 2024

Issue

Overview (Required)

  • Added github action to test for iOS

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@shin-usu shin-usu changed the title [WIP] [WIP] iOS test action Aug 14, 2024
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 14, 2024 15:48 Inactive
}
}
}
final class TimetableTests: XCTestCase {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was removed because it is not appropriate for the current timetable view implementation.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 14, 2024 16:19 Inactive
@shin-usu
Copy link
Contributor Author

shin-usu commented Aug 14, 2024

@ry-itto
Do you know this error? I have tried to resolve it, but I could not...
If you have any ideas, let me know to how to resolve.
Probably, I think you can reproduce it by running the test in your local environment.

Undefined symbols for architecture arm64:
  "CommonComponents.SafariView.init(url: Foundation.URL) -> CommonComponents.SafariView", referenced from:
Error:   "protocol conformance descriptor for CommonComponents.SafariView : SwiftUI.View in CommonComponents", referenced from:
Error:   "type metadata accessor for CommonComponents.SafariView", referenced from:
Error:   "nominal type descriptor for CommonComponents.SafariView", referenced from:
Error: ld: symbol(s) not found for architecture arm64
Error: clang: error: linker command failed with exit code 1 (use -v to see invocation)

If I remove SafariView, errors no longer occur.
It seems that SafariView is the cause.

@ry-itto
Copy link
Member

ry-itto commented Aug 15, 2024

Do you know this error? I have tried to resolve it, but I could not...
If you have any ideas, let me know to how to resolve.

I also encountered this the other day.

Maybe .commonComponents is not included in the dependencies of the target defined in Package.swift. (I thought I had solved the problem, but I may have been stuck and not been able to create a PR yet.)
ContributorFeature is probably the cause, so could you add it there and try it?

@shin-usu
Copy link
Contributor Author

@ry-itto
That makes sense!!
I didn't notice it.
I will try this solution this evening.
Thank you so much😭

@shin-usu shin-usu changed the title [WIP] iOS test action iOS test action Aug 15, 2024
@shin-usu shin-usu marked this pull request as ready for review August 15, 2024 13:57
@@ -220,6 +220,7 @@ let package = Package(
.kmpClient,
.theme,
.model,
.commonComponents,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ry-itto
I could solve it. Thank you!
#455 (comment)

Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks 👍🏼

@ry-itto ry-itto merged commit 2f31ed1 into main Aug 16, 2024
11 checks passed
@ry-itto ry-itto deleted the feature/ios_test_action branch August 16, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Add Test CI
2 participants