[Experimental] Add Dynamic Feature Module (no on-demand) #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your app is deployed! Try it via https://deploygate.com/distributions/0b41907c86db0f71dc34f6019dca808b6bd1f505 |
Apk comparision results
Generated by 🚫 Danger |
jmatsu-bot
reviewed
Jan 26, 2019
| @@ -0,0 +1,3 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"> | |||
There was a problem hiding this comment.
The resource R.xml.preferences appears to be unused |
jmatsu-bot
reviewed
Jan 26, 2019
| @@ -2,4 +2,5 @@ | |||
| <string name="app_name" translatable="false">DroidKaigi 2019</string> | |||
| <string name="app_logo_description" translatable="false">logo image</string> | |||
| <string name="entire_survey_request">Please fill out the entire survey</string> | |||
| <string name="title_staff_dfm">Staff</string> | |||
There was a problem hiding this comment.
The resource R.string.title_staff_dfm appears to be unused |
takahirom
reviewed
Jan 26, 2019
| @@ -28,6 +29,10 @@ open class App : DaggerApplication() { | |||
| @Inject lateinit var systemStore: SystemStore | |||
| @Inject lateinit var systemActionCreator: SystemActionCreator | |||
|
|
|||
| val appCmponent: AppComponent by lazy { | |||
takahirom
reviewed
Jan 26, 2019
| modules = [ | ||
| StaffModule::class | ||
| ], | ||
| dependencies = [AppComponent::class] |
Why experimental
|
|
Brilliant! Very cool 🆒 |
If we can include this PR, probably we will use apk.
How about this? val isContainsDfm = SplitInstallManagerFactory
.create(activity)
.installedModules.contains("staff_dfm")
Navigation.findNavController(activity, R.id.root_nav_host_fragment)
.navigate(
if (isContainsDfm) {
R.id.staff_search
} else {
activityActionCreator.openUrl("https://droidkaigi.jp/2019/staff")
}
) |
I investigated this matter. It seems I had used bundletool but got an error from D8 due to Android Binding related class duplicate. So I've tried to disable DataBinding on stuff_dfm and move related layouts to the base module, then the universal apk is available and works fine. This is just my guess: Workaround
|
|
Perhaps it may be resolved by setting |
|
@takahirom Yes, it works. I'd tried to import progaurd settings and made a universal apk. I confirmed it worked fine! ( we need to disable resource shrinking and use proguard instead of r8 though) |
FYIUsing bundletool in my project which uses AGP 3.3 was working. (My project needs additional proguard.pro configuration though.) |
|
Is that fixed by #669 ? 👀 |
jmatsu-bot
reviewed
Feb 7, 2019
| @@ -2,4 +2,5 @@ | |||
| <string name="app_name" translatable="false">DroidKaigi 2019</string> | |||
There was a problem hiding this comment.
The resource R.string.app_name appears to be unused |
|
@STAR-ZERO If you have any problem, Please tell me. 👀 |
|
I got a below error when run Stacktrace |
|
Does your problem still exist? |
|
Yes 😢 I try to fix but it will take a while. |
|
😢 |
|
Same to me 🤔 |
|
Sorry, I could not pull. 😭 I can reproduce this. |
|
For your reference 🙏 transform register exception cause class Stacktrace |
|
@STAR-ZERO |
takahirom
added a commit
that referenced
this pull request
Feb 11, 2019
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
feature/staff_dfmLinks
Screenshot