Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move from appsignal logger to rails logger #5

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix: Move from appsignal logger to rails logger #5

merged 1 commit into from
Feb 2, 2024
+15 −16

Conversation

KoenSengers
Copy link
Contributor

Change appsignal info method based precense

@KoenSengers KoenSengers force-pushed the issue/4 branch 6 times, most recently from b84a287 to 130b71c Compare February 2, 2024 14:04
MauriceSchekkerman
MauriceSchekkerman approved these changes Feb 2, 2024
View reviewed changes
Copy link

@MauriceSchekkerman MauriceSchekkerman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are sure the deprecated ruby versions can be removed (for the apps of the Eduframe team this should be fine as only Eduframe itself uses this gem).

appsignal-sourcemap.gemspec Show resolved Hide resolved
@KoenSengers KoenSengers force-pushed the issue/4 branch 2 times, most recently from c38191f to 20c48cb Compare February 2, 2024 15:09
@KoenSengers KoenSengers changed the title fix: Change appsignal info method based precense fix: Move from appsignal logger to rails logger Feb 2, 2024
@KoenSengers KoenSengers merged commit 39079a7 into main Feb 2, 2024
4 checks passed
@KoenSengers KoenSengers deleted the issue/4 branch February 2, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauriceSchekkerman MauriceSchekkerman MauriceSchekkerman approved these changes

Assignees

@KoenSengers KoenSengers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KoenSengers @MauriceSchekkerman