Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:添加sigprocmask系统调用 #1046

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

feat:添加sigprocmask系统调用 #1046

wants to merge 13 commits into from

Conversation

sparkzky
Copy link
Contributor

实现sigprocmask系统调用并替换掉原先的散装函数

@dragonosbot
Copy link

r? @GnoCiYeH

dragonosbot has assigned @GnoCiYeH.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@github-actions github-actions bot added the enhancement New feature or request label Nov 13, 2024
@fslongjin fslongjin assigned Chiichen and unassigned GnoCiYeH Nov 13, 2024
Chiichen
Chiichen requested changes Nov 17, 2024
View reviewed changes
kernel/src/ipc/signal.rs Outdated Show resolved Hide resolved
kernel/src/ipc/signal.rs Show resolved Hide resolved
@dragonosbot dragonosbot added the S-等待作者修改 Status: 这正在等待作者的一些操作（例如代码更改或更多信息）。 label Nov 17, 2024
@dragonosbot dragonosbot added the O-x86_64 Target: x86_64 label Nov 18, 2024
@sparkzky
Copy link
Contributor Author

@dragonosbot ready

@dragonosbot dragonosbot added S-等待审查 Status: 等待assignee以及相关方的审查。 and removed S-等待作者修改 Status: 这正在等待作者的一些操作（例如代码更改或更多信息）。 labels Nov 28, 2024
fslongjin
fslongjin reviewed Dec 3, 2024
View reviewed changes
kernel/src/ipc/signal.rs
pub const SIG_UNBLOCK: i32 = 1;
pub const SIG_SETMASK: i32 = 2;

macro_rules! iterate_thread_group {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个只有1个地方用到，不需要写成宏。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fslongjin fslongjin fslongjin left review comments

@Chiichen Chiichen Awaiting requested review from Chiichen

Requested changes must be addressed to merge this pull request.

Assignees

@Chiichen Chiichen

Labels
enhancement New feature or request O-x86_64 Target: x86_64 S-等待审查 Status: 等待assignee以及相关方的审查。
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sparkzky @dragonosbot @Chiichen @fslongjin @GnoCiYeH