Fix Shake Detector not working when app in background #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Dr-Blank
commented
Sep 30, 2024
Dr-Blank
commented
- app was not able to start listening to accelerometer stream once it was in background
- hence this pr avoids disposing of the shake detector by not subscribing to player events and disabling rebuilds when sleep timer is reset
- also since providers are not rebuilt when app is in background, subscribing to event stream is the only way to keep shake detector functional
- it still rebuilds on app settings changes as that can only happen in foreground
Dr-Blank
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.