Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When all items except the disabled item in the left panel of tra… #2574

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Nov 14, 2024

…nsfer are selected, the operation button should display Cancel all selections

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2575
修改前:
image
修改后:
image

本PR修改带来的其他变化:

  1. 当左侧全部为 disabled 时,左侧不会当显示全选/非全选按钮(因为disabled项目不可以通过操作选中)
  2. 当右侧有选项,但是都为 disabled 时,右侧不会显示清空按钮(因为disable的项目无法被清空)

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@YyumeiZhang YyumeiZhang requested a review from YannLynn November 14, 2024 12:11
Copy link

cypress bot commented Nov 14, 2024

semi-design    Run #2936

Run Properties:  status check passed Passed #2936  •  git commit b467a01e8e ℹ️: Merge bc18822fc43055d9e956815ea75ac65d3732f455 into c9d5dba0db98cca7a16a9ed22688...
Project semi-design
Branch Review fix/transfer-selectedAll
Run status status check passed Passed #2936
Run duration 07m 42s
Commit git commit b467a01e8e ℹ️: Merge bc18822fc43055d9e956815ea75ac65d3732f455 into c9d5dba0db98cca7a16a9ed22688...
Committer YyumeiZhang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 275
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

…nsfer are selected, the operation button should display Cancel all selections
@YyumeiZhang YyumeiZhang force-pushed the fix/transfer-selectedAll branch from 3757408 to b017a2a Compare November 14, 2024 12:21
@YyumeiZhang YyumeiZhang merged commit cde4825 into main Nov 18, 2024
6 of 7 checks passed
@YyumeiZhang YyumeiZhang deleted the fix/transfer-selectedAll branch November 18, 2024 07:06
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bc18822:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Nov 18, 2024

semi-design    Run #2937

Run Properties:  status check failed Failed #2937  •  git commit cde4825d2b: fix: When all items except the disabled item in the left panel of tra… (#2574)
Project semi-design
Branch Review main
Run status status check failed Failed #2937
Run duration 07m 53s
Commit git commit cde4825d2b: fix: When all items except the disabled item in the left panel of tra… (#2574)
Committer YyumeiZhang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 274
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants