Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:resize group bugs #2551

Merged
merged 12 commits into from
Nov 18, 2024
Merged

Fix:resize group bugs #2551

merged 12 commits into from
Nov 18, 2024

Conversation

Nathon2Y
Copy link
Contributor

@Nathon2Y Nathon2Y commented Oct 31, 2024 •
edited
Loading

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #

Changelog

🇨🇳 Chinese

  • Fix: 修复计算中浮点数导致伸缩框组件尺寸的误差，浏览器拖动导致的最大最小值失效的问题，以及strictMode引起的问题
  • Feat：ResizeGroup的伸缩方向支持动态切换

🇺🇸 English

  • Fix: fix resizeItem size offset caused by float，invalid min/max setting caused by browser resizing and incorrect behavior in react strictMode
  • Feat：direction in ResizeGroup can be dynamic

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 4, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4e86e42:

Sandbox Source
pr-story Configuration

YyumeiZhang
YyumeiZhang reviewed Nov 12, 2024
View reviewed changes
content/show/resizable/index.md Outdated Show resolved Hide resolved
packages/semi-foundation/resizable/resizable.scss Outdated Show resolved Hide resolved
packages/semi-foundation/resizable/resizable.scss Outdated Show resolved Hide resolved
packages/semi-ui/resizable/group/resizeItem.tsx Show resolved Hide resolved
packages/semi-ui/resizable/group/resizeGroup.tsx Outdated Show resolved Hide resolved
packages/semi-ui/resizable/group/resizeGroup.tsx Show resolved Hide resolved
packages/semi-theme-default/scss/variables.scss Outdated Show resolved Hide resolved
packages/semi-foundation/resizable/resizable.scss Outdated Show resolved Hide resolved
@YyumeiZhang YyumeiZhang merged commit 2ac586b into DouyinFE:release Nov 18, 2024
8 checks passed
@cypress Cypress
Copy link

cypress bot commented Nov 18, 2024

semi-design    Run #2935

Run Properties:  status check passed Passed #2935  •  git commit 2ac586be39: Fix:resize group bugs (#2551)
Project semi-design
Branch Review release
Run status status check passed Passed #2935
Run duration 08m 19s
Commit git commit 2ac586be39: Fix:resize group bugs (#2551)
Committer Nathon2Y
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 275
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YyumeiZhang YyumeiZhang YyumeiZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nathon2Y @YyumeiZhang