Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [InputNumber] Fix the rounded corners of InputNumber, DatePicker… #2497

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Sep 14, 2024

…, Time Pick, and AutoComplete located in the middle of the InputGroup are not 0

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2489

复现代码

export const InputGroupTest = () => {
  return <>
    <InputGroup>
      <Input placeholder="Input" style={{ width: 100 }} />
      <InputNumber placeholder="InpuNumber" style={{ width: 140 }} innerButtons />
      <Input placeholder="Input" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <InputGroup>
      <InputNumber placeholder="InpuNumber" style={{ width: 140 }} innerButtons />
      <Input placeholder="Input" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <InputGroup>
      <Input placeholder="Input" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
      <InputNumber placeholder="InpuNumber" style={{ width: 140 }} innerButtons />
    </InputGroup>
    <br /><br />
    <h3>InputGroup, 按钮在外部,仅位于 group 中间的时候 border-radius 会有问题</h3>
    <InputGroup>
      <Input placeholder="Input" style={{ width: 100 }} />
      <InputNumber placeholder="InpuNumber" style={{ width: 140 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <InputGroup>
      <InputNumber placeholder="InpuNumber" style={{ width: 140 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <InputGroup>
      <Input placeholder="Input" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
      <InputNumber placeholder="InpuNumber" style={{ width: 140 }} />
    </InputGroup>
    <h3>AutoComplete, 仅位于 group 中间会有问题</h3>
    <InputGroup>
      <Input placeholder="Input" style={{ width: 100 }} />
      <AutoComplete placeholder="AutoComplete" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <InputGroup>
      <AutoComplete placeholder="AutoComplete" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <InputGroup>
      <Input placeholder="Input" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
      <AutoComplete placeholder="AutoComplete" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <h3>DatePicker, 仅位于 group 中间的时候 border-radius 会有问题</h3>
    <InputGroup>
      <Input placeholder="Input" style={{ width: 100 }} />
      <DatePicker placeholder="DatePicker" style={{ width: 100 }}/>
      <Input placeholder="Input" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <InputGroup>
      <DatePicker placeholder="DatePicker" style={{ width: 100 }}/>
      <Input placeholder="Input" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <InputGroup>
      <Input placeholder="Input" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
      <DatePicker placeholder="DatePicker" style={{ width: 100 }}/>
    </InputGroup>
    <br /><br />
    <h3>TimePicker, 仅位于 group 中间的时候 border-radius 会有问题</h3>
    <InputGroup>
      <Input placeholder="Input" style={{ width: 100 }} />
      <TimePicker placeholder="TimePicker" style={{ width: 100 }}/>
      <Input placeholder="Input" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <InputGroup>
      <TimePicker placeholder="TimePicker" style={{ width: 100 }}/>
      <Input placeholder="Input" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
    </InputGroup>
    <br /><br />
    <InputGroup>
      <Input placeholder="Input" style={{ width: 100 }} />
      <Input placeholder="Input" style={{ width: 100 }} />
      <TimePicker placeholder="TimePicker" style={{ width: 100 }}/>
    </InputGroup>
    <br /><br />
  </>
}

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

…, Time Pick, and AutoComplete located in the middle of the InputGroup are not 0
Copy link

codesandbox-ci bot commented Sep 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ca3f259:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Sep 14, 2024

semi-design    Run #2845

Run Properties:  status check passed Passed #2845  •  git commit cdab4541e5 ℹ️: Merge ca3f259d42f637a6c11b8b7ef688f56beeddc17e into d05c08d7288c3a4746d26dac4d65...
Project semi-design
Branch Review fix/inputnumber-group
Run status status check passed Passed #2845
Run duration 08m 00s
Commit git commit cdab4541e5 ℹ️: Merge ca3f259d42f637a6c11b8b7ef688f56beeddc17e into d05c08d7288c3a4746d26dac4d65...
Committer YyumeiZhang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 264
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@pointhalo pointhalo merged commit 17ed1ed into main Sep 23, 2024
5 of 7 checks passed
@pointhalo pointhalo deleted the fix/inputnumber-group branch September 23, 2024 09:29
Copy link

cypress bot commented Sep 23, 2024

semi-design    Run #2846

Run Properties:  status check passed Passed #2846  •  git commit 17ed1ed025: fix: [InputNumber] Fix the rounded corners of InputNumber, DatePicker… (#2497)
Project semi-design
Branch Review main
Run status status check passed Passed #2846
Run duration 08m 06s
Commit git commit 17ed1ed025: fix: [InputNumber] Fix the rounded corners of InputNumber, DatePicker… (#2497)
Committer YyumeiZhang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 264
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InputGroup] 如果是inputNumber圆角没有变为0
2 participants