Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix button vertical align with icon #2440

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

DaiQiangReal
Copy link
Collaborator

@DaiQiangReal DaiQiangReal commented Aug 23, 2024

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #2402

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a718845:

Sandbox Source
pr-story Configuration

Copy link

cypress bot commented Aug 23, 2024

semi-design    Run #2766

Run Properties:  status check passed Passed #2766  •  git commit e17ccf98a7 ℹ️: Merge a718845b33d1acc5832531b810ace1067e180a08 into 295b8ff53b343717926b35f06a6e...
Project semi-design
Branch Review fix_button_icon_vertical_align
Run status status check passed Passed #2766
Run duration 10m 12s
Commit git commit e17ccf98a7 ℹ️: Merge a718845b33d1acc5832531b810ace1067e180a08 into 295b8ff53b343717926b35f06a6e...
Committer 代强
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 11
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 268
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@DaiQiangReal
Copy link
Collaborator Author

#2402

@YyumeiZhang YyumeiZhang self-requested a review August 23, 2024 09:51
@YyumeiZhang YyumeiZhang merged commit be0fb99 into main Aug 23, 2024
11 checks passed
@YyumeiZhang YyumeiZhang deleted the fix_button_icon_vertical_align branch August 23, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button的children是图标时,图标垂直方向不居中
2 participants