Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Cascader] Fixed an error caused by untimely update of data in l… #1876

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

YyumeiZhang
Copy link
Collaborator

…oadingKeys

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #1867

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 060d876:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6ab2e8c) 87.99% compared to head (5a4c9e3) 87.98%.
Report is 8 commits behind head on main.

❗ Current head 5a4c9e3 differs from pull request most recent head 060d876. Consider uploading reports for the commit 060d876 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1876      +/-   ##
==========================================
- Coverage   87.99%   87.98%   -0.02%     
==========================================
  Files         436      436              
  Lines       25502    25520      +18     
  Branches     6440     6440              
==========================================
+ Hits        22441    22454      +13     
- Misses       3061     3066       +5     
Files Coverage Δ
packages/semi-foundation/cascader/foundation.ts 91.77% <100.00%> (+1.26%) ⬆️
packages/semi-ui/cascader/index.tsx 93.89% <100.00%> (+0.98%) ⬆️
packages/semi-ui/inputNumber/index.tsx 95.70% <100.00%> (+1.19%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Oct 25, 2023

Passing run #1989 ↗︎

0 226 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 060d876 into 3cb7736...
Project: semi-design Commit: 5a4c9e3f07 ℹ️
Status: Passed Duration: 17:28 💡
Started: Oct 25, 2023 8:18 AM Ended: Oct 25, 2023 8:35 AM

Review all test suite changes for PR #1876 ↗︎

@YyumeiZhang YyumeiZhang merged commit 574fd29 into main Oct 30, 2023
8 checks passed
@YyumeiZhang YyumeiZhang deleted the fix/1867 branch October 30, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants