Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/typography tooltip #1874

Merged
merged 10 commits into from
Oct 30, 2023
Merged

Feat/typography tooltip #1874

merged 10 commits into from
Oct 30, 2023

Conversation

YyumeiZhang
Copy link
Collaborator

@YyumeiZhang YyumeiZhang commented Oct 24, 2023

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

Fixes #1853

Changelog

🇨🇳 Chinese


🇺🇸 English

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@YyumeiZhang YyumeiZhang requested a review from pointhalo October 24, 2023 09:41
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 24, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 57c3156:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@cypress
Copy link

cypress bot commented Oct 24, 2023

Passing run #1992 ↗︎

0 227 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a23e3a4 into d13d8e4...
Project: semi-design Commit: 1587b74614 ℹ️
Status: Passed Duration: 17:06 💡
Started: Oct 26, 2023 8:26 AM Ended: Oct 26, 2023 8:43 AM

Review all test suite changes for PR #1874 ↗︎

@pointhalo pointhalo changed the base branch from main to release October 25, 2023 08:22
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (efec02b) 88.03% compared to head (1587b74) 88.11%.
Report is 1 commits behind head on release.

❗ Current head 1587b74 differs from pull request most recent head a23e3a4. Consider uploading reports for the commit a23e3a4 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #1874      +/-   ##
===========================================
+ Coverage    88.03%   88.11%   +0.08%     
===========================================
  Files          436      436              
  Lines        25503    25503              
  Branches      6438     6441       +3     
===========================================
+ Hits         22452    22473      +21     
+ Misses        3051     3030      -21     
Files Coverage Δ
packages/semi-foundation/table/utils.ts 71.72% <100.00%> (+0.42%) ⬆️
packages/semi-ui/inputNumber/index.tsx 95.70% <100.00%> (+1.19%) ⬆️
packages/semi-ui/tree/index.tsx 89.45% <100.00%> (ø)
packages/semi-ui/treeSelect/index.tsx 89.91% <100.00%> (ø)
packages/semi-ui/typography/base.tsx 95.89% <75.00%> (+0.49%) ⬆️
packages/semi-ui/select/index.tsx 84.32% <0.00%> (+0.17%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pointhalo pointhalo merged commit 0348353 into release Oct 30, 2023
5 checks passed
@pointhalo pointhalo deleted the feat/typography-tooltip branch October 30, 2023 03:22
YyumeiZhang added a commit that referenced this pull request Jan 22, 2024
* feat: [Typography] showTooltip API adds renderTooltip support for custom popup layer components

* feat: Add a className to Popover in Typography

* chore: change param name

* chore: delete .only in e2e test cases

* chore: add e2e test wait time, avoid online test error

* docs: add param type defination for renderTooltip

* docs: The colors used in the examples use Semi official theme colors

* chore: ignore e2e test that work in local but not work in online

---------

Co-authored-by: pointhalo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Typography] Typography.Text 等组件,接管内部的ellipsis的Tooltip/Popover组件渲染
3 participants